2014-03-12 23:12 GMT+08:00 Daniel P. Berrange <berrange@xxxxxxxxxx>:
IMHO this is fixing the wrong side of the inconsistency.On Fri, Mar 07, 2014 at 06:53:09PM +0800, Chunyan Liu wrote:
> Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx>
> ---
> src/libvirt_private.syms | 8 ++++----
> src/qemu/qemu_hostdev.c | 16 +++++++--------
> src/util/virhostdev.c | 52 ++++++++++++++++++++++++------------------------
> src/util/virhostdev.h | 40 ++++++++++++++++++-------------------
> 4 files changed, 58 insertions(+), 58 deletions(-)
>
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 5bb529c..e7d9d56 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -1297,10 +1297,10 @@ virHostdevManagerGetDefault;
> virHostdevPciNodeDeviceDetach;
> virHostdevPciNodeDeviceReAttach;
> virHostdevPciNodeDeviceReset;
> -virHostdevPreparePCIDevices;
> -virHostdevPrepareSCSIDevices;
> -virHostdevPrepareUSBDevices;
> -virHostdevReAttachPCIDevices;
> +virHostdevPreparePciHostdevs;
> +virHostdevPrepareScsiHostdevs;
> +virHostdevPrepareUsbHostdevs;
> +virHostdevReAttachPciHostdevs;
> virHostdevReAttachScsiHostdevs;
> virHostdevReAttachUsbHostdevs;
> virHostdevUpdateActivePciHostdevs;
PCI, USB and SCSI are all abbreviations, so using capitalization
is correct. We should instead fix the Pci, Usb and Scsi names.
Thanks. I'll update.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list