Re: [PATCH 3/7] Move dtrace probe macros into separate header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 05, 2014 at 09:18:54AM -0500, John Ferlan wrote:
> 
> 
> On 03/03/2014 02:18 PM, Daniel P. Berrange wrote:
> > The dtrace probe macros rely on the logging API. We can't make
> > the internal.h header include the virlog.h header though since
> > that'd be a circular include. Instead simply split the dtrace
> > probes into their own header file, since there's no compelling
> > reason for them to be in the main internal.h header.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> > ---
> >  daemon/remote.c              |   1 +
> >  src/internal.h               |  74 --------------------------------
> >  src/qemu/qemu_monitor.c      |   1 +
> >  src/qemu/qemu_monitor_json.c |   1 +
> >  src/qemu/qemu_monitor_text.c |   1 +
> >  src/rpc/virkeepalive.c       |   1 +
> >  src/rpc/virnetclient.c       |   1 +
> >  src/rpc/virnetserverclient.c |   1 +
> >  src/rpc/virnetsocket.c       |   1 +
> >  src/rpc/virnettlscontext.c   |   1 +
> >  src/util/vireventpoll.c      |   1 +
> >  src/util/virobject.c         |   1 +
> >  src/util/virprobe.h          | 100 +++++++++++++++++++++++++++++++++++++++++++
> >  13 files changed, 111 insertions(+), 74 deletions(-)
> >  create mode 100644 src/util/virprobe.h
> > 
> 
> <...snip...>
> 
> > --- /dev/null
> > +++ b/src/util/virprobe.h
> > @@ -0,0 +1,100 @@
> > +/*
> > + * virlog.h: internal logging and debugging
> 
> NIT:  virprobe.h

Yep

> > + *
> > + * Copyright (C) 2006-2008, 2011-2012 Red Hat, Inc.
> > + *
> 
> Should this be just 2014 or the range?

I've changed to 2006-2014


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]