On 03/07/2014 04:51 PM, Eric Blake wrote:
> On 03/07/2014 06:45 AM, Ján Tomko wrote:
>> Some of these are leftovers from renaming the files, others
>> are just typos.
>>
>> Also introduce an ugly awk script to enforce this.
>> ---
>> cfg.mk | 25 +++++++++++++++++++++++++
>
>> +++ b/cfg.mk
>> @@ -863,6 +863,31 @@ sc_prohibit_atoi:
>> halt='Use virStrToLong* instead of atoi, atol, atof, atoq, atoll' \
>> $(_sc_search_regexp)
>>
>> +# Don't
>> +sc_prohibit_wrong_filename_in_comment:
>> + @fail=0; \
>> + awk 'BEGIN { \
>> + fail=0; \
>
> Looks like a lot of indentation. You could collapse it to 2- or 4-space
> indents, so you aren't having such long lines everywhere (you need the
> initial TAB indent to keep make happy, but that doesn't mean everything
> else needs that much).
With space indents, my make seems to be happy.
Mixing tabs with spaces breaks syntax-check with that much indentation:
maint.mk: found TAB-8-space indentation
make: *** [sc_makefile_TAB_only_indentation] Error 1
All the other checks in the file use TAB with max. 3 additional 2-space
indents. The other awk check mixes tabs and spaces, but gets around the
8-space limit by incorrecty indenting the deepest levels.
I removed the extra level of indentation, converted all but first tabs to
spaces and pushed it.
Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list