On Fri, Mar 07, 2014 at 06:30:30AM -0700, Eric Blake wrote: > On 03/07/2014 06:18 AM, Martin Kletzander wrote: > > On Fri, Mar 07, 2014 at 01:59:31PM +0100, Michal Privoznik wrote: > >> On 07.03.2014 12:59, Daniel P. Berrange wrote: > >>> There is a forever growing list of test cases. It is just > >>> not worth listing each one individually when a wildcard > >>> can do the job. > >>> > >>> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > >>> --- > >>> .gitignore | 73 +------------------------------------------------------------- > >>> 1 file changed, 1 insertion(+), 72 deletions(-) > >>> > >> > >> ACK > >> > > > > Wait, according to `git ls-files | grep '^tests/.*test$'` > > > > these files would be added as well (even though they shouldn't): > > > > tests/capabilityschematest > > tests/domainschematest > > tests/domainsnapshotschematest > > tests/interfaceschematest > > tests/networkschematest > > tests/nodedevschematest > > tests/nwfilterschematest > > tests/secretschematest > > tests/storagepoolschematest > > tests/storagevolschematest > > These can all be re-added via a negative pattern: > > !/tests/*schematest > > > tests/virt-aa-helper-test > > and we could also do a negative pattern for this, or just rename it. > > But I agree that we shouldn't exclude these files, as the logic on what > 'git commit -a' commits gets weird when you have a pattern that excludes > a file already checked in. Yes, of course. I'm pushing with this change: +/tests/*test +!/tests/*schematest +!/tests/virt-aa-helper-test which makes 'git commit -a' work properly in my test Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list