Re: [PATCH] Fix locking in virsh console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 10, 2014 at 03:04:15PM +0400, Roman Bogorodskiy wrote:
> vshRunConsole() uses virCondWait() which is a wrapper around
> pthread_cond_wait(). On FreeBSD, pthread_cond_wait needs mutex to be
> locked, otherwise it immediately fails with EPERM. On Linux, the
> behaviour in this case is undefined.
> 
> So lock the mutex before calling virCondWait().
> ---
>  tools/virsh-console.c | 5 +++++
>  1 file changed, 5 insertions(+)

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]