On 03/06/2014 08:39 PM, Eric Blake wrote: > On 03/06/2014 08:24 AM, Laine Stump wrote: >> These format functions needed the ability to be indented by an >> arbitrary amount, but were written before the introduction of >> virBufferAdjustIndent(). They instead used the much more clunky method >> of adding a "level" arg to every format function, and padding with >> spaces using the "%*s" printf format specifier (giving it the level, >> and "", which has the effect of adding level spaces to the output). >> >> While eliminating the hardcoded indentation in other xml, I decided it >> was finally time to also modernize the interface formatter code to >> make it more consistent. >> --- >> src/conf/interface_conf.c | 137 ++++++++++++++++++++++------------------------ >> 1 file changed, 64 insertions(+), 73 deletions(-) > About time! You're telling me! It was me that originally put in the "%*s" usage, which seemed cool at the time, but looks really silly in comparison to having indentation built into virBuffer*. > >> diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c >> index 8053307..65ab2fa 100644 >> --- a/src/conf/interface_conf.c >> +++ b/src/conf/interface_conf.c >> @@ -1,7 +1,7 @@ >> /* >> * interface_conf.c: interfaces XML handling >> * >> - * Copyright (C) 2006-2010, 2013 Red Hat, Inc. >> + * Copyright (C) 2006-2010, 2013, 2014 Red Hat, Inc. > Per git log, Red Hat people touched this file in 2011 and 2012, so you > could simplify this to 2006-2014. Yeah, whenever I notice a comma-separated list of copyright dates on a Red Hat notice, I check the log for commits from @redhat.com addresses during the missing years, and merge them if possible. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list