On Thu, Mar 06, 2014 at 06:57:14 -0700, Eric Blake wrote:
> On 03/06/2014 06:37 AM, Jiri Denemark wrote:
> > On Thu, Mar 06, 2014 at 06:20:37 -0700, Eric Blake wrote:
> >> On 03/06/2014 04:06 AM, Jiri Denemark wrote:
> >>> Libvirt tarball contains po/stamp-po file which prevents any po/*.gmo
> >>> file to be regenerated even if a corresponding po/*.po file is newer. By
> >>> removing the stamp-po file, all *.gmo files are properly updated if
> >>> required. This allows downstreams to provide patches that update
> >>> translations.
>
> >>
> >> I think you need to guard this:
> >>
> >>>
> >> %if 0%{?enable_autotools}
> >>> +rm -f po/stamp-po
> >> %endif
> >
> > I don't think so.
> >
>
> > gettext is an unconditional BuildRequires in libvirt.spec so we always
> > require it to be present (unlike gettext-devel which is only required if
> > enable_autotools is 1). And msgfmt used for generating gmo files from po
> > files is present in gettext package.
>
> Fair enough. ACK to your patch as-is, then.
OK, pushed. Thanks,
Jirka
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list