On Wed, Mar 05, 2014 at 02:15:51PM +0800, Chunyan Liu wrote: > 2014-03-04 0:57 GMT+08:00 Cedric Bosdonnat <cbosdonnat@xxxxxxxx>: > > > Hello ChunYan, > > > > I saw a few minor problems in some patches that made me rebase quite a > > lot of other patches in your serie, but otherwise it really looks good > > to me. > > > > Here is a summary of the changes I made or questions I have: > > * Patch 2: Fixed a few remaining changes that broke the build. > > Just remember that having the tree building after each commit > > helps a lot when one later needs to bisect. > > * Patch 4: when is the manager freed? > > > It's hard to find a specified code point to free the manager, since we > don't know is there anyone else still using it. If we now keep a reference to the manager in the virQEMUDriver struct and the same for the LXC/libxl drivers, then you could turn the virHostdevManagerPtr struct into a virObject. Then you can use ref counting to make it get free'd when the drivers shutdown. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list