Re: [PATCH 2/7] Refactor code that skips logging of error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/03/2014 12:18 PM, Daniel P. Berrange wrote:
> The virRaiseErrorFull method sends all error messages onto the

s/onto/on to/

> logging code. The logging code has some logic to skip emission
> when no log outputs are configured which checks the virLogSource.
> This will complicate later refactoring, and the check can easily
> be done in the virRaiseErrorFull method instead of in the logging
> code.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/util/virerror.c | 14 ++++++++++----
>  src/util/virlog.c   |  2 +-
>  2 files changed, 11 insertions(+), 5 deletions(-)
> 

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]