Re: [PATCHv2 1/2] Split out most of virDBusIsServiceEnabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/03/2014 08:47 AM, Ján Tomko wrote:
> Introduce virDBusIsServiceInList which can be used to call other
> methods for listing services (ListNames), not just ListActivatableNames.

Nice refactoring.

> 
> No functional change.
> ---
>  src/util/virdbus.c | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)
> 

>  
> -/**
> - * virDBusIsServiceEnabled:
> - * @name: service name
> - *
> - * Retruns 0 if service is available, -1 on fatal error, or -2 if service is not available

Hmm, the "Retruns" typo...

> - */
> -int virDBusIsServiceEnabled(const char *name)
> +static int virDBusIsServiceInList(const char *listMethod, const char *name)

Here's your chance to use the two-line formatting:

static int
virDBusIs...(...)


>  
> +/**
> + * virDBusIsServiceEnabled:
> + * @name: service name
> + *
> + * Retruns 0 if service is available, -1 on fatal error, or -2 if service is not available

...merely moved down.  Please fix it while touching here :)

> + */
> +int virDBusIsServiceEnabled(const char *name)

Two-line formatting might be nice.

My findings are cosmetic, so ACK whether you address them or not.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]