Re: [PATCH] virDomainBlockStats(Flags): Produce saner error message on empty disk path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 28, 2014 at 10:18:09AM +0100, Michal Privoznik wrote:
> As of 0bd2ccdec an empty disk path for virDomainBlockStats (or the one
> with Flags) is allowed meaning "get me overall summarized statistics".
> However, running 'virsh domblkstat $dom' throws a misleading error:
>
>   # ./tools/virsh domblkstat dom
>   error: Failed to get block stats dom
>   error: invalid argument: invalid path:
>
> while after this commit
>
>   # virsh domblkstat dom
>   error: Operation not supported: summary statistics are not supported yet
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---

ACK and worth this release, thanks!

Martin

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]