On 02/24/2014 12:27 PM, Laine Stump wrote: >>> >> ACK although the indentation of XML we're passing to the hook script seems off: > > Right. That's what the last paragraph of the commit log message is about > - fixing that indentation would require a much more invasive change that > would touch all the other device parsing functions, which could turn any > potential backport into a real headache, so I chose to not fix it in > this series. Correct - whitespace cleanups in a separate commit, especially in order to ease backport efforts, is a good tradeoff to make. >> This is not a show stopper for me. I wonder if we should push these patches now, even during the freeze as this is very closely related to the network hooks - one of the main features in this release. > > In a way it is a bugfix for that feature (since the functionality of the > "plugged" hook is severely limited without it). I would feel more > comfortable about pushing it, though, if danpb took a look at the commit > log message for patch 5/7 and gave his okay on the change in the XML. My > opinion is that I should have done it this way to begin with, but Dan > has much better insight than I do on what is and isn't good for > management applications. I agree with getting Dan's opinion, but you have my ACK for including this in time for 1.2.2 as a bug fix of the hook feature. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list