On Thu, Feb 20, 2014 at 04:19:54PM +0000, Daniel P. Berrange wrote: > On Thu, Feb 20, 2014 at 05:15:08PM +0100, Martin Kletzander wrote: > > When enum type has '_LAST' in its name, but is not the last type in > > that enum, it's skipped even though it shouldn't be. Currently, this > > is the case for only VIR_NETWORK_UPDATE_COMMAND_ADD_LAST inside an > > enum virNetworkUpdateCommand. > > > > Also, since _LAST types can have other enums instead of values, that > > needs to be filtered out using a try-except when converting the value. > > > > Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> > > --- > > generator.py | 19 ++++++++++++++----- > > 1 file changed, 14 insertions(+), 5 deletions(-) > > ACK. > Thanks, pushed. > Perhaps also extend sanitytest.py to check enums ? > I skimmed through the file and I have to go through that once more to be able apprehend the goal of it. However I'll keep it on top of my to-do list. Martin > Daniel > -- > |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- http://virt-manager.org :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list