Am 14.02.2014 15:30, schrieb Daniel P. Berrange: > On Fri, Feb 14, 2014 at 03:21:01PM +0100, Richard Weinberger wrote: >> Currently we enforce that every container has a cgroup. >> So we can delete these two !priv->cgroup branches. >> >> Signed-off-by: Richard Weinberger <richard@xxxxxx> >> --- >> Hi! >> >> Maybe I miss something but I think we can delete these two !priv->cgroup branches. >> If virLXCCgroupCreate() returns NULL the LXC controller exists. > > Unfortunately there's an issue that 'virLXCProcessStop' method > can be called from 'virLXCProcessStart' when container startup > fails and in this case we don't guarantee cgroup != NULL. Hmm, I see the issue. Maybe I find a nice solution to clean this up. Thanks, //richard -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list