Re: [PATCH v3 00/21] LXC configuration conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 05, 2014 at 03:09:58PM +0100, Cédric Bosdonnat wrote:
> Here is an updated version of the patch set fixing comments from Daniel.
> It also adds 3 commits:
>   * One adding conversion for the newly supported blkio throttle tune
>     in lxc driver.
>   * One actually using the state of the veth network device in lxc
>     driver.
>   * One adding the ability to give major:minor numbers instead of a path
>     for blkio tune devices.
> 
> The last one is a way to address Daniel's comment on the /dev/block/...
> paths.
> 
> Cédric Bosdonnat (21):
>   Improve virConf parse to handle LXC config format
>   LXC driver: started implementing connectDomainXMLFromNative
>   LXC from native: import rootfs
>   LXC from native: migrate fstab and lxc.mount.entry
>   LXC from native: implement no network conversion
>   LXC from native: migrate veth network configuration
>   LXC from native: convert phys network types to net hostdev devices
>   LXC from native: convert lxc.tty to console devices
>   LXC from native: convert macvlan network configuration
>   LXC from native: convert lxc.id_map into <idmap>
>   LXC from native: migrate memory tuning
>   LXC from native: map lxc.cgroup.cpu.*
>   LXC from native: map lxc.cgroup.cpuset.*
>   LXC from native: add lxc.cgroup.blkio.* mapping
>   LXC from native: map lxc.arch to /domain/os/type@arch
>   LXC from native: map block filesystems
>   LXC from native: map vlan network type
>   LXC: added some doc on domxml-from-native with mention of limitations
>   LXC from native: convert blkio throttle config
>   lxc: honor link state=up for veth interfaces
>   blkiotune: allow <node major='' minor=''/> in place of <path>
> 
>  .gitignore                                         |   1 +
>  docs/drvlxc.html.in                                |  34 +-
>  docs/formatdomain.html.in                          |  10 +-
>  po/POTFILES.in                                     |   1 +
>  src/Makefile.am                                    |   1 +
>  src/conf/domain_conf.c                             |  45 +-
>  src/conf/domain_conf.h                             |   2 +
>  src/libvirt_private.syms                           |   1 +
>  src/lxc/lxc_cgroup.c                               |   5 +
>  src/lxc/lxc_container.c                            |   2 +-
>  src/lxc/lxc_container.h                            |   2 +
>  src/lxc/lxc_driver.c                               |  41 +
>  src/lxc/lxc_native.c                               | 952 +++++++++++++++++++++
>  src/lxc/lxc_native.h                               |  32 +
>  src/lxc/lxc_process.c                              |   5 +
>  src/qemu/qemu_cgroup.c                             |   5 +
>  src/qemu/qemu_driver.c                             |  10 +
>  src/util/vircgroup.c                               | 126 ++-
>  src/util/vircgroup.h                               |  10 +
>  src/util/virconf.c                                 |  46 +-
>  src/util/virconf.h                                 |  10 +
>  tests/Makefile.am                                  |   7 +-
>  tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config |  11 +
>  tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml    |  39 +
>  .../lxcconf2xmldata/lxcconf2xml-cpusettune.config  |   6 +
>  tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml   |  27 +
>  tests/lxcconf2xmldata/lxcconf2xml-cputune.config   |   7 +
>  tests/lxcconf2xmldata/lxcconf2xml-cputune.xml      |  29 +
>  tests/lxcconf2xmldata/lxcconf2xml-fstab.config     |  37 +
>  tests/lxcconf2xmldata/lxcconf2xml-idmap.config     |   5 +
>  tests/lxcconf2xmldata/lxcconf2xml-idmap.xml        |  28 +
>  .../lxcconf2xml-macvlannetwork.config              |  13 +
>  .../lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml |  26 +
>  tests/lxcconf2xmldata/lxcconf2xml-memtune.config   |  10 +
>  tests/lxcconf2xmldata/lxcconf2xml-memtune.xml      |  29 +
>  .../lxcconf2xmldata/lxcconf2xml-nonenetwork.config |   4 +
>  tests/lxcconf2xmldata/lxcconf2xml-nonenetwork.xml  |  21 +
>  tests/lxcconf2xmldata/lxcconf2xml-nonetwork.config |   3 +
>  tests/lxcconf2xmldata/lxcconf2xml-nonetwork.xml    |  24 +
>  .../lxcconf2xmldata/lxcconf2xml-physnetwork.config |   6 +
>  tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml  |  26 +
>  tests/lxcconf2xmldata/lxcconf2xml-simple.config    |  41 +
>  tests/lxcconf2xmldata/lxcconf2xml-simple.xml       |  41 +
>  .../lxcconf2xmldata/lxcconf2xml-vlannetwork.config |  12 +
>  tests/lxcconf2xmldata/lxcconf2xml-vlannetwork.xml  |  26 +
>  tests/lxcconf2xmltest.c                            | 131 +++
>  46 files changed, 1865 insertions(+), 85 deletions(-)
>  create mode 100644 src/lxc/lxc_native.c
>  create mode 100644 src/lxc/lxc_native.h
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cpusettune.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cputune.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-cputune.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-fstab.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-idmap.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-idmap.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-macvlannetwork.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-memtune.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-memtune.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonenetwork.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonenetwork.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonetwork.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-nonetwork.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-physnetwork.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-simple.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-simple.xml
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-vlannetwork.config
>  create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-vlannetwork.xml
>  create mode 100644 tests/lxcconf2xmltest.c

This series is now pushed, except patches 20/21, with the various OOM
crash and memory leak bugs I discovered during testing.

Thanks for this great new feature!

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]