On 02/12/2014 08:04 AM, Cedric Bosdonnat wrote:
> On Wed, 2014-02-12 at 06:31 -0700, Eric Blake wrote:
>> On 02/12/2014 03:36 AM, Cédric Bosdonnat wrote:
>>> Two unused global variables, and DBUS_TYPE_INVALID used as a const
>>> char*.
>>> ---
>>> src/phyp/phyp_driver.c | 1 -
>>> src/storage/storage_backend_scsi.c | 24 ------------------------
>>> src/util/virdbus.c | 2 +-
>>> 3 files changed, 1 insertion(+), 26 deletions(-)
>>
>>
>>> +++ b/src/storage/storage_backend_scsi.c
>>> @@ -107,30 +107,6 @@ struct diskType {
>>> unsigned long long magic;
>>> };
>>>
>>> -static struct diskType const disk_types[] = {
>>
>> This is the only use of 'struct diskType'; please also remove that
>> declaration a couple lines earlier.
>
> Weird that clang didn't report that one after the patch.
Unused variables are different than unused types. And if clang were to
warn about unused types, we'd be in trouble: gnulib's verify() module
depends on the ability to create dummy unused types.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list