Re: [PATCH 5/6] qemu: enable monitor event reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 31, 2014 at 07:12:10PM -0700, Eric Blake wrote:
> Wire up all the pieces to send arbitrary qemu events to a
> client using libvirt-qemu.so.  If the extra bookkeeping of
> generating event objects even when no one is listening turns
> out to be noticeable, we can try to further optimize things
> by adding a counter for how many connections are using events,
> and only dump events when the counter is non-zero; but for
> now, I didn't think it was worth the code complexity.
> 
> * src/qemu/qemu_driver.c
> (qemuConnectDomainQemuMonitorEventRegister)
> (qemuConnectDomainQemuMonitorEventDeregister): New functions.
> * src/qemu/qemu_monitor.h (qemuMonitorEmitEvent): New prototype.
> (qemuMonitorDomainEventCallback): New typedef.
> * src/qemu/qemu_monitor_json.c (qemuMonitorJSONIOProcessEvent):
> Report events.
> * src/qemu/qemu_monitor.c (qemuMonitorEmitEvent): New function, to
> pass events through.
> * src/qemu/qemu_process.c (qemuProcessHandleEvent): Likewise.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c       | 52 ++++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor.c      | 16 +++++++++++++-
>  src/qemu/qemu_monitor.h      | 13 ++++++++++-
>  src/qemu/qemu_monitor_json.c | 23 ++++++++++++++++++--
>  src/qemu/qemu_process.c      | 29 ++++++++++++++++++++++++
>  5 files changed, 129 insertions(+), 4 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]