Hi,
Is there any chance that this serie be reviewed before the next freeze ?
The v1 was sent back in June and since then we need to maintain our own custom
package with our patches in it because we need this feature. We're a very
small team and it's quite time consuming.
Regards,
Jean-Baptiste
On Thursday 23 January 2014 10:28:28 Manuel VIVES wrote:
> Hi,
> This is a serie of patches in order to support undefining and redefining
> snapshots with VirtualBox 4.2.
>
> The serie of patches is rather big, and adds among other things some
> utility functions unrelated to VirtualBox in patches 1 & 2.
> The code review could be done in several parts: e.g. patches 1 & 2
> separately to validate the utility functions.
>
> The VirtualBox API provides only high level operations to manipulate
> snapshots, so it not possible to support flags like
> VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and
> VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY with only API calls.
> Following an IRC talk with Eric Blake, the decision was taken to emulate
> these behaviours by manipulating directly the .vbox XML files.
>
> The first two patches are some util methods for handling regexp and strings
> that will be used after.
>
> The third patch brings more details in the snapshot XML returned by
> libvirt. We will need those modifications in order to redefine the
> snapshots.
>
> The fourth patch brings the support of the
> VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT
> flags in virDomainSnapshotCreateXML.
>
> The fifth and last patch brings the support of the
> VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY
> flag in virDomainSnapshotDelete.
>
> The patches are only tested with Virtualbox 4.2 but the code is
> compliant with Virtualbox 4.3 API.
>
> Regards,
> Manuel VIVES
>
> v6:
> * Rebased because of a massive change in vbox_tmpl.c due to changes in
> the handling of different versions of VirtualBox
>
> v5:
> * The patches are modified according to a first review by Laine Stump:
> * renamed virSearchUuid to virSearchRegex and moved it from
> viruuid.{c,h} to virstring.{c,h}.
> * Various fixes.
>
> V4:
> * The code is compliant with Virtualbox 4.3 API
> * Some minor modifications in order to satisfy "make syntax-check"
>
> V3:
> * Use of STREQ_NULLABLE instead of STREQ in one case
> * Fix the method for finding uuids according to Ján Tomko review
>
> V2:
> * Fix a licence problem with the method for string replacement
>
>
> Manuel VIVES (5):
> virstring.h/c: Util method for finding regexp patterns in some
> strings
> virstring.h/c: Util method for making some find and replace in
> strings
> vbox_tmpl.c: Better XML description for snapshots
> vbox_tmpl.c: Patch for redefining snapshots
> vbox_tmpl.c: Add methods for undefining snapshots
>
> po/POTFILES.in | 1 +
> src/libvirt_private.syms | 2 +
> src/util/virstring.c | 163 +++-
> src/util/virstring.h | 4 +
> src/vbox/vbox_tmpl.c | 2346
> ++++++++++++++++++++++++++++++++++++++++++---- 5 files changed, 2346
> insertions(+), 170 deletions(-)
--
Jean-Baptiste ROUAULT
R&D Engineer - diateam : Architectes de l'information
Phone : +33 (0)2 98 050 050 Fax : +33 (0)2 98 050 051
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list