Re: [PATCH 2/4] domain: parse and format os.bootStrict from/to XML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/07/14 15:10, Daniel P. Berrange wrote:
> On Fri, Feb 07, 2014 at 03:07:38PM +0100, Laszlo Ersek wrote:
>> On 02/07/14 15:00, Daniel P. Berrange wrote:
>>> On Wed, Jan 22, 2014 at 01:33:20AM +0100, Laszlo Ersek wrote:
>>>> Signed-off-by: Laszlo Ersek <lersek@xxxxxxxxxx>
>>>> ---
>>>>  src/conf/domain_conf.c        | 21 +++++++++++++++++++++
>>>>  docs/formatdomain.html.in     |  9 +++++++++
>>>>  docs/schemas/domaincommon.rng | 10 ++++++++++
>>>>  3 files changed, 40 insertions(+)
>>>
>>>
>>>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>>>> index ff50214..bf21c46 100644
>>>> --- a/docs/formatdomain.html.in
>>>> +++ b/docs/formatdomain.html.in
>>>> @@ -106,6 +106,7 @@
>>>>      &lt;boot dev='hd'/&gt;
>>>>      &lt;boot dev='cdrom'/&gt;
>>>>      &lt;bootmenu enable='yes'/&gt;
>>>> +    &lt;boot-strict enable='yes'/&gt;
>>>>      &lt;smbios mode='sysinfo'/&gt;
>>>>      &lt;bios useserial='yes' rebootTimeout='0'/&gt;
>>>>    &lt;/os&gt;
>>>
>>> Reviving the thread. Based on the discussions, I think I now agree that
>>> your suggestion to allow toggle of strict mode is probably our least
>>> worst way forward.
>>>
>>> I'd suggest that instead of introducing a new element here, we add
>>> an attribute to the <bios> element. eg perhaps this:
>>>
>>>   <bios bootPolicy="strict|fallback">
>>>
>>>
>>> BTW, as a general goal we want all the parsing/xml related changes
>>> in one patch. So your patches 1 + 2 could be squashed together.
>>
>> Oh, I've implemented HALT parsing in OVMF since. See
>>
>>   https://github.com/tianocore/edk2/commit/c3cf8daa
>>
>> I considered the issue solved, with the above OVMF commit. Do you still
>> want me to rework this libvirt series? I can if you want me to.
> 
> Based on your explanations it sounds like being able to turn off
> strict mode could still potentially be useful to people. So feel
> free to rework this series if you think its useful - I won't reject

Thank you. I'm re-appending it to my queue.

Laszlo

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]