On Thu, Feb 06, 2014 at 01:56:17PM -0700, Eric Blake wrote: > On 02/06/2014 11:09 AM, Christophe Fergeau wrote: > > > > > +/* Check if VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_POOL_TYPE seems to > > + * contain all virConnectListAllStoragePoolsFlags elements > > + */ > > +verify(VIR_CONNECT_LIST_STORAGE_POOLS_LAST < VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_POOL_TYPE); > > + > > +/* Check if virConnectListAllStorageFlags has one flag per known storage > > + * pool type */ > > +verify(1 << (5+VIR_STORAGE_POOL_LAST) == VIR_CONNECT_LIST_STORAGE_POOLS_LAST - 1); > > Wow, that does look pretty ugly and hard-coded. At this point, I'm not > sure that adding it buys us much. Agreed about the ugliness ;) I won't spend more time on this. Christophe
Attachment:
pgpy1XkMZZpDa.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list