Re: [PATCH v2] qemuxml2argvtest: Set timezone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/06/2014 03:11 PM, Michal Privoznik wrote:
> With my recent work on the test, both time() and localtime() are used.
> While mocking the former one, we get predictable result for UTC. But
> since the latter function uses timezone to get local time, the result of
> localtime() is not so predictive. Therefore, we must set the TZ variable
> at the beginning of the test. To be able to catch some things that work
> just by a blind chance, I'm choosing a virtual timezone that (hopefully)
> no libvirt developer resides in.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  .../qemuxml2argv-clock-localtime-basis-localtime.args          |  2 +-
>  tests/qemuxml2argvtest.c                                       | 10 ++++++++++
>  2 files changed, 11 insertions(+), 1 deletion(-)

ACK, please push.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]