On 01/30/2014 12:50 PM, John Ferlan wrote: > Rework changes from code review > v2 here: http://www.redhat.com/archives/libvir-list/2014-January/msg01473.html > > v3 changes over v2: > * Changed configure.ac for "RMMOD" definition > * Use "virKMod*()" instead of "virModprobe*()" for function names > * Adjust virKModLoad() to take boolean parameter for using -b or not > * Add virKModIsBlacklisted() to perform the blacklist check > * Adjust virkmodtest.c to use the virCommandSetDryRun() > > John Ferlan (3): > utils: Introduce functions for modprobe > tests: Add test for new virkmod functions > Honor blacklist for modprobe command > > .gitignore | 2 + > configure.ac | 6 ++ > src/Makefile.am | 1 + > src/libvirt_private.syms | 7 ++ > src/util/virkmod.c | 182 ++++++++++++++++++++++++++++++++++++++++++++++ > src/util/virkmod.h | 34 +++++++++ > src/util/virpci.c | 28 +++++--- > tests/Makefile.am | 5 ++ > tests/virkmodtest.c | 183 +++++++++++++++++++++++++++++++++++++++++++++++ > 9 files changed, 439 insertions(+), 9 deletions(-) > create mode 100644 src/util/virkmod.c > create mode 100644 src/util/virkmod.h > create mode 100644 tests/virkmodtest.c > Thanks for the reviews, series now pushed John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list