On Tue, Feb 04, 2014 at 08:29:53AM -0700, Eric Blake wrote: > On 02/04/2014 03:32 AM, Martin Kletzander wrote: > > On Tue, Feb 04, 2014 at 11:14:34AM +0100, Christophe Fergeau wrote: > >> On Tue, Feb 04, 2014 at 10:57:45AM +0100, Martin Kletzander wrote: > >>> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> > >>> --- > >>> tools/wireshark/Makefile.am | 1 + > >>> tools/wireshark/src/Makefile.am | 2 +- > >>> 2 files changed, 2 insertions(+), 1 deletion(-) > > > > > So this is already pushed, but feel free to add the sample as well, at > > least it will be part of the tar.gz. I don't know where to put it in > > the specfile, though. > > I'm now seeing this failure: > > Checking for unpackaged file(s): /usr/lib/rpm/check-files > /home/eblake/rpmbuild/BUILDROOT/libvirt-1.2.2-1.fc20.x86_64 > error: Installed (but unpackaged) file(s) found: > /usr/lib64/wireshark/plugins/1.10.5/libvirt.la > /usr/lib64/wireshark/plugins/1.10.5/libvirt.so > > Do we need to create a new subpackage for libvirt-wireshark, where we > stick both the .so and the examples? Yes, indeed. It seems this part got missed Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list