Re: [PATCH] qemu: minor cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 03, 2014 at 09:31:11PM +0100, Martin Kletzander wrote:
> On Mon, Feb 03, 2014 at 06:52:49PM +0100, Christophe Fergeau wrote:
> > Not sure this one improves things, the type of the enum is in the
> > namespacing of the values anyway (VIR_DOMAIN_CHR_TYPE_*), and it's only
> > done for a minority of the switch() calls in domain_conf.c
> >
> I like the idea of listing all the enums and compiler reminding about
> places depending on them.

Yup, I did not realize the cast would let the compiler warn about missing
enum values, so just disregard my comment about the casts. Thanks to Eric
and you for the explanation :)

Christophe


Attachment: pgp9QCKWZ62RU.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]