On 01/23/2014 08:19 AM, Oleg Strikov wrote:
> This patch allows libvirt user to specify 'host-passthrough'
> cpu mode while using qemu/kvm backend on aarch64.
> It uses 'host' as a CPU model name instead of some other stub
> (correct CPU detection is not implemented yet) to allow libvirt
> user to specify 'host-model' cpu mode as well.
>
> Signed-off-by: Oleg Strikov <oleg.strikov@xxxxxxxxxxxxx>
> ---
> src/cpu/cpu_aarch64.c | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
I'm not sure about the technical aspect of the patch, but for the style
aspect:
>
> static int
> -AArch64Decode(virCPUDefPtr cpu ATTRIBUTE_UNUSED,
> +AArch64Decode(virCPUDefPtr cpu,
> const virCPUData *data ATTRIBUTE_UNUSED,
> const char **models ATTRIBUTE_UNUSED,
> unsigned int nmodels ATTRIBUTE_UNUSED,
> const char *preferred ATTRIBUTE_UNUSED,
> unsigned int flags)
As long as you are touching this, can you fix up the botched
indentation? It should look like:
AArch64Decode(virCPUDefPtr cpu,
const virCPUData *data ATTRIBUTE_UNUSED,
with secondary lines under the first byte after (.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list