On Fri, Jan 17, 2014 at 3:12 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > GVirConfigDomainTimerPit is correctly define as inheriting from > GVirConfigDomainTimer in the G_DEFINE_TYPE macro, but it only > embeds GVirConfigObject/GVirConfigObjectClass structs. > > This is an ABI break as this changes the size of the > GVirConfigDomainTimerPit/GVirConfigDomainTimerPitClass structs > However, since these structs only have non-public members, users of the > library will not be trying to access fields of the struct past the first > field (which is the one which changed size). This would also be an issue > if anything had subclassed GVirConfigDomainTimerPit, which is unlikely at > this point. > All in all, it's imo more convenient to silently fix this without an soname > bump. I've tested that GNOME Boxes built with an older version of > libvirt-gconfig still generates the correct GVirConfigDomainTimerPit > elements when using a version of libvirt-gconfig with this patch. ACK. Extra points for providing all the details and testing against Boxes. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list