On 01/15/2014 06:50 PM, Daniel P. Berrange wrote: > On Wed, Jan 15, 2014 at 04:47:21PM +0800, Gao feng wrote: >> the array params is allocated by VIR_ALLOC_N in cmdCPUStats. >> it had been set to zero. No need to reset it to zero again, >> and this reset here is incorrect too, nparams * ncpus is the >> array length not the size of params array. > > 'cmdCPUStats' is virsh client code. The QEMU driver is > running server side in libvirtd. So whatever memory was > allocated in cmdCPUStats isn't the same as the memory > used in qemu_driver.c > ohh.. this memory is allocated by VIR_ALLOC_N in remoteDispatchDomainGetCPUStats.. I will change the changelog and resend this patch. Thanks! -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list