On 01/02/2014 05:23 PM, John Ferlan wrote: > > > On 12/28/2013 11:11 AM, Eric Blake wrote: >> virStoragePoolBuild reported an invalid pool as if it were an >> invalid network. Likewise, we weren't consistent on whether to >> use VIR_FROM_NONE or VIR_FROM_STORAGE. Similar to previous >> patches, use a common macro to make it nicer. For now, we >> don't need virCheckStoragePoolGoto(). >> >> * src/datatypes.h (virCheckStoragePoolReturn): New macro. >> (VIR_IS_STORAGE_POOL, VIR_IS_CONNECTED_STORAGE_POOL): Drop >> unused macros. >> * src/libvirt.c: Use macro throughout. >> (virLibStoragePoolError): Drop unused macro. >> >> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >> --- >> src/datatypes.h | 17 ++++-- >> src/libvirt.c | 172 +++++++++++++------------------------------------------- >> 2 files changed, 51 insertions(+), 138 deletions(-) >> > > Same as previous w/r/t connection required for GetName, GetUUID, and > GetUUIDString And same answer, fixed by improving the commit message. > > ACK Pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list