On 01/07/2014 05:39 AM, Richard W.M. Jones wrote: > On Tue, Jan 07, 2014 at 11:37:11AM +0100, Martin Kletzander wrote: >> On Tue, Jan 07, 2014 at 10:28:41AM +0000, Richard W.M. Jones wrote: >>> On Thu, Jan 02, 2014 at 06:29:35PM +0200, Pavel Fux wrote: >>>> Adding an option to change monitor socket opening timeout >>>> the current default is 3 seconds and in some cases it's not enough >>> >>> This should change the *default* to something way bigger than 3 >>> seconds, since lots of people are hitting this. Just look at the >>> dozen Ubuntu forum posts and many other bug reports: >>> >>> https://www.google.co.uk/search?q="monitor+socket+did+not+show+up"; >>> >>> Sure it can be configurable if you want, but I don't want to have to >>> tell each and every libguestfs user that they should change this to >>> something sensible. Make the default something much larger. >>> >> >> I agree with you here, we could change it to at least 5 seconds *and* >> make it configurable. I'll propose the change of the default in >> separate patch and try reviewing this ASAP. > > Is there a reason not to make it 30 seconds? > > The only downside I can see is that if qemu is really hanging/broken > users will have to wait 30 seconds to see that it is hanging, versus > waiting 3 or 5 seconds. I can't see that is much of a drawback. > I agree that bumping the timeout to 30 seconds should be fine: qemu actually hanging before the monitor socket is setup is something I never hear about, so the large timeout shouldn't matter much in practice. So ACK to raising it to 30. - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list