On 01/07/2014 08:48 AM, John Ferlan wrote: > > > On 01/06/2014 05:27 PM, Eric Blake wrote: >> On the surface, this sequence of API calls should succeed: >> >> id1 = virConnectDomainEventRegisterAny(..., VIR_DOMAIN_EVENT_ID_LIFECYCLE,...); >> id2 = virConnectDomainEventRegisterAny(..., VIR_DOMAIN_EVENT_ID_RTC_CHANGE,...); >> virConnectDomainEventDeregisterAny(id1); >> id1 = virConnectDomainEventRegisterAny(..., VIR_DOMAIN_EVENT_ID_LIFECYCLE,...); >> >> And for test:///default, it does. But for qemu:///system, it fails: >> libvirt: XML-RPC error : internal error: domain event 0 already registered >> > > Strangely enough - I was going to remark about the usage of 'deleted' in > the previous patch deleted code as being a bit unusual.. Yep - part of the inconsistency was whether the various open-coded iterations considered or skipped deleted callbacks; having all the code go through a common function sure helps in understanding what is going on. > > ACK Pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list