Re: [PATCH] lxc_controller: Fix error message on missing --handshakefd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/07/2014 07:56 AM, Michal Privoznik wrote:
> The argument is --handshakefd not --handshake.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/lxc/lxc_controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK.

> 
> diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
> index 1b43bd2..a2ae599 100644
> --- a/src/lxc/lxc_controller.c
> +++ b/src/lxc/lxc_controller.c
> @@ -2365,7 +2365,7 @@ int main(int argc, char *argv[])
>      }
>  
>      if (handshakeFd < 0) {
> -        fprintf(stderr, "%s: missing --handshake argument for container PTY\n",
> +        fprintf(stderr, "%s: missing --handshakefd argument for container PTY\n",

Not in this patch, but we should probably add _() marking to all the
error messages in main() after the point of our textdomain() call
earlier, so that a user typing the command line will get a localized
error message.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]