On 01/04/2014 03:27 PM, Eric Blake wrote: > On 01/03/2014 04:06 AM, Ján Tomko wrote: >> Do not leave the PCI address of the primary video card set >> to the legacy default (0000:00:02.0) if we're doing two-pass >> allocation. >> >> Since QEMU 1.6 (QEMU_CAPS_VIDEO_PRIMARY) we allow the primary >> video card to be on other slots than 0000:00:02.0 (as we use >> -device instead of -vga). >> >> However we fail to assign it an address if: >> * another device explicitly uses 0000:00:02.0 and >> * the primary video device has no address specified >> >> On the first pass, we have set the address to default, then checked >> if it's available, leaving it set even if it wasn't. This address >> got picked up by the second pass, resulting in a conflict: >> >> XML error: Attempted double use of PCI slot 0000:00:02.0 >> (may need "multifunction='on'" for device on function 0) >> >> Also fix the test that was supposed to catch this. >> --- > > ACK. > Now pushed. Thank you! Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list