On Tue, Dec 31, 2013 at 07:22:53AM -0700, Eric Blake wrote: > Prior to this patch, an attempt to register an event without an > event loop started results in the vague: > > libvirt: Remote Driver error : adding cb to list > > Now it gives the much nicer: > > libvirt: error : internal error: could not initialize domain event timer > > This also avoids hiding other reasonable error messages, such as > attempts to register a duplicate callback or OOM errors. > > Also, document the event loop usage requirement, since that was how > I ran into the issue. > > * src/remote/remote_driver.c (remoteConnectNetworkEventRegisterAny) > (remoteConnectDomainEventRegister) > (remoteConnectDomainEventRegisterAny): Preserve more detailed error. > * src/libvirt.c (virConnectDomainEventRegister) > (virConnectDomainEventRegisterAny) > (virConnectNetworkEventRegisterAny): Document event loop requirement. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > src/libvirt.c | 24 +++++++++++++++--------- > src/remote/remote_driver.c | 12 +++--------- > 2 files changed, 18 insertions(+), 18 deletions(-) > ACK, although I wasn't (somehow) able to test it with python bindings. Martin
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list