Re: [PATCHv2] maint: improve debug of libvirt-{qemu, lxc} apis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/19/2013 09:32 PM, Eric Blake wrote:
> I noticed that the virDomainQemuMonitorCommand debug output wasn't
> telling me the name of the domain it was working on.  While it was
> easy enough to determine which pointer matches the domain based on
> other log messages, it is nicer to be consistent.
> 
> * src/util/viruuid.h (VIR_UUID_DEBUG): Moved here from...
> * src/libvirt.c (VIR_UUID_DEBUG): ...here.
> (VIR_ARG15, VIR_HAS_COMMA, VIR_DOMAIN_DEBUG_EXPAND)
> (VIR_DOMAIN_DEBUG_PASTE, VIR_DOMAIN_DEBUG_0, VIR_DOMAIN_DEBUG_1)
> (VIR_DOMAIN_DEBUG_2, VIR_DOMAIN_DEBUG): Move...
> * src/datatypes.h: ...here.
> * src/libvirt-qemu.c (virDomainQemuMonitorCommand)
> (virDomainQemuAgentCommand): Better debug messages.
> * src/libvirt-lxc.c (virDomainLxcOpenNamespace): Likewise.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
> 
> The simpler part of my changes; the work on cleaning up the
> remaining virLib*Error() calls in libvirt.c is turning into
> a bigger cleanup project.

Bigger project now posted (and supersedes this patch):
https://www.redhat.com/archives/libvir-list/2013-December/msg01284.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]