On Tuesday 24 December 2013 17:00:19 Eric Blake wrote: > On 12/24/2013 08:47 AM, Jean-Baptiste Rouault wrote: > > While working on adding virDomain*Stats support to the vbox driver, we > > found bugs in the VirtualBox API C bindings. These bugs have been fixed > > in versions 4.2.20 and 4.3.4. > > However, the changes in the C bindings are incompatible with the > > vbox_CAPI_v4_2.h and vbox_CAPI_v4_3.h files which are bundled in libvirt > > source code. This is why the following patch adds vbox_CAPI_v4_2_20.h > > and vbox_CAPI_v4_3_4.h. > > > > We tried to keep compatibility with older VirtualBox 4.2.x and 4.3.x > > releases so we added a "SPECIAL_VERSION" identifier to conditionnaly > > include the right header. I'm not really pleased with this > > "SPECIAL_VERSION" identifier, maybe we could instead increase the > > precision of "VBOX_API_VERSION", for example 4002 would become 4002000. > > This would permit us to select the right header based on the > > VBOX_API_VERSION only, what do you think ? > > > > Jean-Baptiste Rouault (1): > > vbox: add support for v4.2.20+ and v4.3.4+ > > > > src/Makefile.am | 4 +- > > src/vbox/vbox_CAPI_v4_2_20.h | 9001 +++++++++++++++++++++++++++++++++++ > > src/vbox/vbox_CAPI_v4_3_4.h | 10321 > > +++++++++++++++++++++++++++++++++++++++++ > > This patch is HUGE (620k, so the moderation queue is currently holding > it as oversized, compared to the normal 150k limit). Is there any way > to break it into smaller pieces, or compress it before sending to the > list, or merely point to an external repo containing the patch, so that > we aren't chewing up lots of bandwidth on mostly mechanical code? The patch is available at http://git-lab.diateam.net/cots/libvirt.git/ The branch is named "vbox-4.2.20-4.3.4-support" Regards, -- Jean-Baptiste ROUAULT R&D Engineer - diateam : Architectes de l'information Phone : +33 (0)2 98 050 050 Fax : +33 (0)2 98 050 051 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list