Re: [PATCH v2] PanicCheckABIStability: Need to check for existence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/21/2013 05:22 AM, John Ferlan wrote:
> Commit id '4313fead' added a call to virDomainPanicCheckABIStability()
> which did not check whether the panic device existed before making a call
> to virDomainDeviceInfoCheckABIStability() which ended up segfaulting:
> 

> Also seen using following sequence:
> 
> virsh save $dom $file
> virsh save-image-edit $file
>   add (or remove) a <panic/> line
>   <devices>
>   ...
>     <panic>
>       <address type='isa' iobase='0x505'/>
>     </panic>
>   ...
>   </devices>
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
> 
> Changes since v1 -
>    Added !src && !dst check, which results in:
> 
>  error: unsupported configuration: Target domain panic device count '0' does not match source count '1'

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]