Re: [PATCH] virkeycode: Allow ANSI_A

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 19, 2013 at 04:46:50PM +0100, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1044806
> 
> Currently, sending the ANSI_A keycode from os_x codepage doesn't work as
> it has a special value of 0x0. Our internal code handles that no
> different to other not defined keycodes. Hence, in order to allow it we
> must change all the undefined keycodes from 0 to -1 and adapt some code
> too.
> 
>   # virsh send-key guestname --codeset os_x ANSI_A
>   error: invalid keycode: 'ANSI_A'
> 
>   # virsh send-key guestname --codeset os_x ANSI_B
>   # virsh send-key guestname --codeset os_x ANSI_C
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/util/virkeycode-mapgen.py | 4 ++--
>  src/util/virkeycode.c         | 4 ++--
>  tools/virsh-domain.c          | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)

ACK, that's a fun bug :-)

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]