On 12/19/13 05:54, Eric Blake wrote: > On 12/16/2013 09:32 AM, Peter Krempa wrote: >> Recent adition of the gluster pool type omitted fixing the virsh and > > s/adition/addition/ > >> virConnectListAllStoragePool filters. A typecast of the converting >> function in virsh showed that also the sheepdog pool was omitted in the >> command parser. >> >> This patch adds gluster pool filtering support and fixes virsh to >> properly convert all supported storage pool types. The added typecast >> should avoid doing such mistakes in the future. >> --- >> include/libvirt/libvirt.h.in | 1 + >> src/conf/storage_conf.c | 4 +++- >> tools/virsh-pool.c | 9 +++++++-- >> 3 files changed, 11 insertions(+), 3 deletions(-) > > Missing a doc change in virsh.pod, to mention that 'gluster' is also a > valid type. > > Code is fine, so ACK if you fix the missing docs. > I've fixed the man page and pushed the patch. Thanks. Peter
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list