Re: [PATCH RFC 10/27] storage: Avoid forward declaration of virStorageVolDelete

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/2013 09:32 AM, Peter Krempa wrote:
> Move the code around so that the forward declaration isn't needed.
> ---
>  src/storage/storage_driver.c | 181 ++++++++++++++++++++++---------------------
>  1 file changed, 91 insertions(+), 90 deletions(-)

ACK; mechanical.

> 
> diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
> index f08255e..8b1dcae 100644
> --- a/src/storage/storage_driver.c
> +++ b/src/storage/storage_driver.c
> @@ -1495,7 +1495,97 @@ cleanup:
>      return ret;
>  }
> 
> -static int storageVolDelete(virStorageVolPtr obj, unsigned int flags);
> +
> +static int
> +storageVolDelete(virStorageVolPtr obj,
> +                 unsigned int flags) {

This { should be on its own line; but you were doing straight code
motion so it's okay if you don't clean it up until a later patch.  (Or
you could clean it up here, as long as the commit message mentions that
you did minor tweaking to fix style issues as part of the code motion)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]