Re: [PATCH] Fix race leading to crash when setting up dbus watches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/18/2013 05:21 AM, Daniel P. Berrange wrote:
> Currently the virDBusAddWatch does
> 
>   virEventAddHandle(fd, flags,
>                     virDBusWatchCallback,
>                     watch, NULL);
>   dbus_watch_set_data(watch, info, virDBusWatchFree);
> 
> Unfortunately this is racy - since the event loop is in a
> different thread, the virDBusWatchCallback method may be
> run before we get to calling dbus_watch_set_data. We must
> reverse the order of these calls
> 
> See https://bugzilla.redhat.com/show_bug.cgi?id=885445
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/util/virdbus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]