Re: [PATCH] configure: make --with-test-suite work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/18/2013 12:03 AM, Martin Kletzander wrote:
> Our option '--with-test-suite' could have never worked since it was
> defined as AC_ARG_ENABLE([with-test-suite], ...), thus working only as
> '--enable-with-test-suite', but documented in configure.ac as
> AC_HELP_STRING([--with-test-suite], ...).
> In my optinion, the help string is as it should be, but the option is

s/optinion/opinion/

> wrong.
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  configure.ac | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Indeed, you could use './configure --disable-with-test-suite' to change
the behavior, but that just looks wrong.  It's been broken since the
introduction in commit 3a2fc27.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]