On 12/12/2013 11:55 AM, Michal Privoznik wrote: >> int detail; >> -}; >> +} ATTRIBUTE_PACKED; > > (What an ancient e-mail :-) ) 1970 was how many years before libvirt was even started? > > I've raised the problem here: > > https://www.redhat.com/archives/libvir-list/2013-December/msg00635.html > > And Eric replied suggesting a fix: > > https://www.redhat.com/archives/libvir-list/2013-December/msg00662.html > > But I must say I like your approach more. Eric? I still think ATTRIBUTE_PACKED in a parent class is wrong; it forces the children to be packed, and may make it impossible to implement atomic operations on a child member that was supposed to be aligned. I'd much rather fix the alignment in the parent class using portable constructs than a compiler-specific non-alignment directive. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list