Re: [PATCH 0/2] Fix interface state transitions logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/12/2013 07:41 AM, Daniel P. Berrange wrote:
> 
> The usage you describe here is not within the scope of the
> virInterfaceCreate()  API IMHO. If we want users to have the
> ability to "re start" an interface without taking it offline
> first, then we should add another API that explicitly supports
> that use case.

Or even a flag to the existing argument that says to restart if already
running, where the normal case of not having the flag is an error if
already running.

> Overloading a single virInterfaceCreate to support two different use
> cases puts applications in an impossible position if they *want* to
> see an error from attempting to start an already active interface.

Overloading without the use of a flag bit, that is.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]