On Thu, Dec 12, 2013 at 08:59:33AM +0100, Martin Kletzander wrote:
> On Wed, Dec 11, 2013 at 04:31:46PM +0000, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> >
> > This updates autobuild.sh to test the python3 build process.
> > The RPM specfile is changed to build a libvirt-python3 RPM
> > on Fedora > 18
> >
> > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> > ---
> > autobuild.sh | 6 ++++++
> > libvirt-python.spec.in | 57 +++++++++++++++++++++++++++++++++++++++++++-------
> > 2 files changed, 56 insertions(+), 7 deletions(-)
> >
> > diff --git a/autobuild.sh b/autobuild.sh
> > index b3beaf1..c7d2661 100755
> > --- a/autobuild.sh
> > +++ b/autobuild.sh
> > @@ -13,6 +13,12 @@ python setup.py build
> > python setup.py test
> > python setup.py install --root="$AUTOBUILD_INSTALL_ROOT"
> >
>
> I haven't tested it, but shouldn't these lines ^^, and others similar
> to them, be changed to "python2" in case my default python version is
> 3? And if those "python2" are checked as well, it would be usable
> even without python2.
Yes, we should use python2
> Or just use %{__python2} and %{__python3} as Eric suggested.
Those macros only work in RPM, not autobuild.sh
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list