On Wed, Dec 11, 2013 at 11:37:59AM +0100, Cédric Bosdonnat wrote:
> ---
> src/test/test_driver.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> @@ -6027,6 +6056,37 @@ testConnectDomainEventDeregisterAny(virConnectPtr conn,
> }
>
>
> +static int
> +testConnectNetworkEventRegisterAny(virConnectPtr conn,
> + virNetworkPtr net,
> + int eventID,
> + virConnectNetworkEventGenericCallback callback,
> + void *opaque,
> + virFreeCallback freecb)
> +{
> + testConnPtr driver = conn->privateData;
> + int ret;
> +
> + testDriverLock(driver);
> + if (virNetworkEventStateRegisterID(conn,
> + driver->domainEventState,
> + net, eventID,
> + VIR_OBJECT_EVENT_CALLBACK(callback),
> + opaque, freecb, &ret) < 0)
> + ret = -1;
> + testDriverUnlock(driver);
> +
> + return ret;
> +}
> +
> +static int
> +testConnectNetworkEventDeregisterAny(virConnectPtr conn,
> + int callbackID)
Indentation.
> +{
> + return testConnectDomainEventDeregisterAny(conn, callbackID);
> +}
We generally aim to avoid having one public API calling into another
one, so I'm going to expand this to the explicit code.
ACK and will fix issues before pushing.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list