On 11/12/13 01:31, Chris Lalancette wrote: > On Tue, Dec 10, 2013 at 8:35 AM, Chris Lalancette <clalancette@xxxxxxxxx> wrote: >>> gcc -I. -I. >>> -I/usr/local/rvm/rubies/ruby-1.8.7-p371/lib/ruby/1.8/x86_64-linux -I. >>> -DRUBY_EXTCONF_H=\"extconf.h\" -fPIC -g -O2 -fPIC -c common.c >>> common.c: In function ‘ruby_libvirt_typed_parameter_assign’: >>> common.c:385: error: ‘ST_CONTINUE’ undeclared (first use in this function) >>> common.c:385: error: (Each undeclared identifier is reported only once >>> common.c:385: error: for each function it appears in.) >>> common.c: In function ‘ruby_libvirt_set_typed_parameters’: >>> common.c:405: error: dereferencing pointer to incomplete type >>> make: *** [common.o] Error 1 > > Yeah, it turns out that ST_CONTINUE is in <st.h> in ruby 1.8 and > <ruby/st.h> in later versions. Luckily the old <st.h> still works on > later version (albeit with a warning). I fixed that, and also added a > compatibility hack in the Rakefile that allows it to build on ruby > 1.8. With both of those in place, I'm now able to build on > CentOS-6.4. I've pushed these compatibility hacks to the main > ruby-libvirt repository. > > At the moment, I'm not planning to put out a new release for this > minor fix. Dominic, if you really want this in an official release, > let me know and I can do a 0.5.1. Otherwise I'll just let you handle > it when building a package for RHEL-6/CentOS-6. > > Thanks again for the bug report. Thanks for the fix Chris. A new release would be much appreciated as we're hitting this issue on gems, not RPMs. Our CI for Foreman (http://theforeman.org/) runs under a few Ruby versions and picked up this new version of the gem, so we'll need to pin to < 0.5 otherwise. Regards, -- Dominic Cleal Red Hat Engineering -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list