Re: [PATCH] storage: fix omitted slash in gluster volume URI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/10/2013 07:34 AM, Laine Stump wrote:
> On 12/10/2013 02:50 PM, Eric Blake wrote:
>> When doing 'virsh vol-dumpxml' on a gluster pool's volume, the
>> resulting URI incorrectly omitted a slash between hostname and
>> path:  gluster://192.168.122.206rhsvol1/fedora-19.img
>>
>> This is fallout from me rebasing earlier versions of my patch,
>> I had originally played with always requiring the gluster volume
>> to have a leading slash, but it was easier to use the gluster
>> API if the gluster volume name was guaranteed to have no slash;
>> while I got the URI of the pool correct, I forgot to fix the URI
>> of a libvirt volume.
>>
>> * src/storage/storage_backend_gluster.c
>> (virStorageBackendGlusterRefreshVol): Use correct starting point
>> since uri construction requires leading slash.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>>
>> Once approved, I'm also pushing to v1.2.0-maint
> 
> 
> ACK. This fixes the problem.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]