On Tue, Dec 03, 2013 at 10:29:58AM -0800, Ian Main wrote: > On Thu, Nov 21, 2013 at 03:27:46PM +0100, Christophe Fergeau wrote: > > This seems to be exactly the same code as what you added in > > libvirt-sandbox-builder-container.c, this should go into a helper > > (gvir_sandbox_config_network_filterref_get_config(), or > > gvir_sandbox_builder_get_network_filterref_config() I think). > > Yes, I'm actually not entirely sure how to handle that.. there is a lot > of duplicate code between the two but a few things that are different. > I think we might have to refactor that part but I think maybe we need a > builder_common.c or something. Both classes derive from GVirSandboxBuilder, so common code could go there. Regarding the duplicated code you add, it seems it could directly be moved to a common function without much refactoring. Christophe
Attachment:
pgpsE9Yeb7fh6.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list