Re: [PATCH] storage: skip selinux cleanup when fd not available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/26/2013 11:43 PM, Osier Yang wrote:
> On 27/11/13 12:00, Eric Blake wrote:
>> When attempting to backport gluster pools to an older version
>> where there is no VIR_STRDUP, I got a crash from calling
>> strdup(,NULL).  Rather than relying on the current else branch
>> safely doing nothing when there is no fd, it is easier to just
>> skip it. While at it, there's no need to explicitly set
>> perms.label to NULL after a VIR_FREE().
>>
>> * src/storage/storage_backend.c
>> (virStorageBackendUpdateVolTargetInfoFD): Minor optimization.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---

> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]