[PATCH python] Make block pull event dispatcher private

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>

The method dispatchDomainEventBlockPullCallback which is
used internally to dispatch block pull events to the python
application code was missing the leading '_', to denote that
it was private.  All other event callback helpers have a
leading '_'. No application should have been using this so
it is justifiable to rename it.

Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
---
 libvirt-override-virConnect.py | 2 +-
 libvirt-override.c             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libvirt-override-virConnect.py b/libvirt-override-virConnect.py
index 4ba3d30..23fadfd 100644
--- a/libvirt-override-virConnect.py
+++ b/libvirt-override-virConnect.py
@@ -113,7 +113,7 @@
            authScheme, subject, opaque)
         return 0
 
-    def dispatchDomainEventBlockPullCallback(self, dom, path, type, status, cbData):
+    def _dispatchDomainEventBlockPullCallback(self, dom, path, type, status, cbData):
         """Dispatches events to python user domain blockJob event callbacks
         """
         try:
diff --git a/libvirt-override.c b/libvirt-override.c
index 4cc64b7..d3802de 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -5998,7 +5998,7 @@ libvirt_virConnectDomainEventBlockJobCallback(virConnectPtr conn ATTRIBUTE_UNUSE
 
     /* Call the Callback Dispatcher */
     pyobj_ret = PyObject_CallMethod(pyobj_conn,
-                                    (char*)"dispatchDomainEventBlockPullCallback",
+                                    (char*)"_dispatchDomainEventBlockPullCallback",
                                     (char*)"OsiiO",
                                     pyobj_dom, path, type, status, pyobj_cbData);
 
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]